From 12f9f4dcdc15ee320f2430098cf0f71528c11e79 Mon Sep 17 00:00:00 2001 From: KevIsDev Date: Tue, 27 May 2025 12:14:50 +0100 Subject: [PATCH] fix: remove unused isStreaming prop from quickActions The isStreaming prop was passed through multiple chat components but wasn't being strict enough in the Markdown component where it was ultimately passed causing the quick actions to be disabled. --- app/components/chat/AssistantMessage.tsx | 15 ++------------- app/components/chat/Markdown.tsx | 4 +--- app/components/chat/Messages.client.tsx | 1 - 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/app/components/chat/AssistantMessage.tsx b/app/components/chat/AssistantMessage.tsx index 13908d8..2d013b8 100644 --- a/app/components/chat/AssistantMessage.tsx +++ b/app/components/chat/AssistantMessage.tsx @@ -16,7 +16,6 @@ interface AssistantMessageProps { append?: (message: Message) => void; chatMode?: 'discuss' | 'build'; setChatMode?: (mode: 'discuss' | 'build') => void; - isStreaming?: boolean; } function openArtifactInWorkbench(filePath: string) { @@ -44,17 +43,7 @@ function normalizedFilePath(path: string) { } export const AssistantMessage = memo( - ({ - content, - annotations, - messageId, - onRewind, - onFork, - append, - chatMode, - setChatMode, - isStreaming, - }: AssistantMessageProps) => { + ({ content, annotations, messageId, onRewind, onFork, append, chatMode, setChatMode }: AssistantMessageProps) => { const filteredAnnotations = (annotations?.filter( (annotation: JSONValue) => annotation && typeof annotation === 'object' && Object.keys(annotation).includes('type'), @@ -152,7 +141,7 @@ export const AssistantMessage = memo( - + {content} diff --git a/app/components/chat/Markdown.tsx b/app/components/chat/Markdown.tsx index 28ced46..2402228 100644 --- a/app/components/chat/Markdown.tsx +++ b/app/components/chat/Markdown.tsx @@ -18,11 +18,10 @@ interface MarkdownProps { append?: (message: Message) => void; chatMode?: 'discuss' | 'build'; setChatMode?: (mode: 'discuss' | 'build') => void; - isStreaming?: boolean; } export const Markdown = memo( - ({ children, html = false, limitedMarkdown = false, append, setChatMode, isStreaming }: MarkdownProps) => { + ({ children, html = false, limitedMarkdown = false, append, setChatMode }: MarkdownProps) => { logger.trace('Render'); const components = useMemo(() => { @@ -102,7 +101,6 @@ export const Markdown = memo( data-message={message} data-path={path} data-href={href} - disabled={isStreaming} onClick={() => { if (type === 'file') { openArtifactInWorkbench(path); diff --git a/app/components/chat/Messages.client.tsx b/app/components/chat/Messages.client.tsx index 037d26c..6dc8d7f 100644 --- a/app/components/chat/Messages.client.tsx +++ b/app/components/chat/Messages.client.tsx @@ -100,7 +100,6 @@ export const Messages = forwardRef( append={props.append} chatMode={props.chatMode} setChatMode={props.setChatMode} - isStreaming={isStreaming} /> )}