fix: implement stream recovery to prevent chat hanging (#1977)

- Add StreamRecoveryManager for handling stream timeouts
- Monitor stream activity with 45-second timeout
- Automatic recovery with 2 retry attempts
- Proper cleanup on stream completion

Fixes #1964

Co-authored-by: Keoma Wright <founder@lovemedia.org.za>
This commit is contained in:
Keoma Wright
2025-09-07 20:26:10 +02:00
committed by GitHub
parent 2f6f28e67e
commit 2fde6f8081
2 changed files with 107 additions and 0 deletions

View File

@@ -13,6 +13,7 @@ import { createSummary } from '~/lib/.server/llm/create-summary';
import { extractPropertiesFromMessage } from '~/lib/.server/llm/utils';
import type { DesignScheme } from '~/types/design-scheme';
import { MCPService } from '~/lib/services/mcpService';
import { StreamRecoveryManager } from '~/lib/.server/llm/stream-recovery';
export async function action(args: ActionFunctionArgs) {
return chatAction(args);
@@ -39,6 +40,14 @@ function parseCookies(cookieHeader: string): Record<string, string> {
}
async function chatAction({ context, request }: ActionFunctionArgs) {
const streamRecovery = new StreamRecoveryManager({
timeout: 45000,
maxRetries: 2,
onTimeout: () => {
logger.warn('Stream timeout - attempting recovery');
},
});
const { messages, files, promptId, contextOptimization, supabase, chatMode, designScheme, maxLLMSteps } =
await request.json<{
messages: Messages;
@@ -83,6 +92,8 @@ async function chatAction({ context, request }: ActionFunctionArgs) {
const dataStream = createDataStream({
async execute(dataStream) {
streamRecovery.startMonitoring();
const filePaths = getFilePaths(files || {});
let filteredFiles: FileMap | undefined = undefined;
let summary: string | undefined = undefined;
@@ -314,9 +325,12 @@ async function chatAction({ context, request }: ActionFunctionArgs) {
(async () => {
for await (const part of result.fullStream) {
streamRecovery.updateActivity();
if (part.type === 'error') {
const error: any = part.error;
logger.error('Streaming error:', error);
streamRecovery.stop();
// Enhanced error handling for common streaming issues
if (error.message?.includes('Invalid JSON response')) {
@@ -328,6 +342,7 @@ async function chatAction({ context, request }: ActionFunctionArgs) {
return;
}
}
streamRecovery.stop();
})();
result.mergeIntoDataStream(dataStream);
},